This repository has been archived by the owner on Apr 19, 2021. It is now read-only.
Enable nullglobs to prevent string literal bug in various for loops #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take this code as an example:
for i in /nsm/sensor_data/*/stats.log; do
echo "$i"
if [ $( tail -n 50 $i | grep -c drop ) -ne 0 ]; then
If there are no files that match '/nsm/sensor_data/*/status.log', the
non-intuitive default setting in shell scripts is to assign the literal
'/nsm/sensor_data/*/status.log' to $i. This then breaks the following if
statement because tail is being passed a filename with a wildcard in it.
|
Thanks @zestysoft ! |
dougburks
added a commit
that referenced
this pull request
Sep 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take this code as an example:
for i in /nsm/sensor_data/*/stats.log; do
echo "$i"
if [ $( tail -n 50 $i | grep -c drop ) -ne 0 ]; then
If there are no files that match '/nsm/sensor_data//status.log', the
non-intuitive default setting in shell scripts is to assign the literal
'/nsm/sensor_data//status.log' to $i. This then breaks the following if
statement because tail is being passed a filename with a wildcard in it.