Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Suricata dns.response.code needs to be renamed to dns.response.code_name #4770

Closed
dougburks opened this issue Jul 12, 2021 · 1 comment
Closed

FIX: Suricata dns.response.code needs to be renamed to dns.response.code_name #4770

dougburks opened this issue Jul 12, 2021 · 1 comment
Assignees
@dougburks
Labels
must

Comments

@dougburks
Copy link
Contributor

Currently, the Suricata DNS parser renames dns.rcode to dns.response.code:
https://github.com/Security-Onion-Solutions/securityonion/blob/master/salt/elasticsearch/files/ingest/suricata.dns#L15

However, we actually need that to be dns.response.code_name to match what we do with Zeek DNS logs:
https://github.com/Security-Onion-Solutions/securityonion/blob/master/salt/elasticsearch/files/ingest/zeek.dns#L16

And to align with our Hunt DNS Response query:
https://github.com/Security-Onion-Solutions/securityonion/blob/master/salt/soc/files/soc/hunt.queries.json#L25
@dougburks dougburks added the must label Jul 12, 2021
@dougburks dougburks self-assigned this Jul 12, 2021
dougburks added a commit that referenced this issue Jul 12, 2021
@dougburks
FIX: Suricata dns.response.code needs to be renamed to dns.response.c…
e6f9592 
…ode_name #4770
@dougburks dougburks mentioned this issue Jul 12, 2021
Merged
dougburks added a commit that referenced this issue Jul 12, 2021
@dougburks
Merge pull request #4775 from Security-Onion-Solutions/fix/suricata-d…
2ea3989 
…ns-response-code

FIX: Suricata dns.response.code needs to be renamed to dns.response.code_name #4770
@dougburks
Copy link
Contributor Author

Tested a fresh dev installation in local VM and confirmed working properly:
image

jertel pushed a commit that referenced this issue Jul 22, 2021
@dougburks @jertel
FIX: Suricata dns.response.code needs to be renamed to dns.response.c…
3d3593a 
…ode_name #4770
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougburks dougburks

Labels
must
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dougburks