FIX: soup should check for local configurations before modifying anything

[dougburks]

Soup currently notifies users that they have local modifications. From https://docs.securityonion.net/en/2.3/soup.html#local-configurations:

soup will check for local configurations in /opt/so/saltstack/local/ that may cause issues and flag them with the message Potentially breaking changes found in the following files. Please examine the output of soup and review any local configurations for possible issues.

However, this only fires if soup completes successfully without error. In some cases, soup is erroring (maybe even due to the local config change itself) and so that message never fires.

soup should also run that check at the very beginning to let folks know that they have local modifications before it ever upgrades anything.

Of course, there will be some local configs that are perfectly fine so we wouldn't want soup to exit altogether when it reports that. Maybe just a Press Enter to continue or Ctrl-c to cancel prompt.

[weslambert]

#8485

[dougburks]

Tested and confirmed:

Potentially breaking changes found in the following files (check /opt/so/saltstack/default for original copy):
  /opt/so/saltstack/local/salt/soc/files/soc/menu.actions.json

To reference this list later, check /root/soup.log.

Please review the local modifications shown above as they may cause problems during or after the update.

Would you like to proceed with the update anyway?

If so, type 'YES'. Otherwise, type anything else to exit SOUP.

[dougburks]

Additional commit:
#8558