FIX: Remove intca symlink on reinstall #12290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symlink is created in init.sls; it should be removed here.
|
FYI, I'm working on having the ability to upgrade form ubuntu 20.04 with v2.3.280 to 22.04 with v2.4 without needing to reinstall the OS. This file was one of the issues causing the installation of v2.4.40 to fail. Under v2.3, it's a file, but v2.4 expects it to be a symlink. |
|
Also, when reinstall_init() is called, should the calls to the remove state at securityonion/setup/so-functions Line 2164 in 483bf60 |
salt-call does not work when the salt-master is not running. If these calls are to succeed, they should occur before the salt services are stopped.
TOoSmOotH
approved these changes
Feb 12, 2024
TOoSmOotH
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symlink is created in init.sls; it should be removed here.