Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ in usernames #742

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Allow @ in usernames #742

merged 3 commits into from
Feb 5, 2023

Conversation

jonas-plum
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #742 (ff33845) into main (188ca25) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
+ Coverage   66.40%   66.50%   +0.10%     
==========================================
  Files          75       75              
  Lines        9560     9575      +15     
==========================================
+ Hits         6348     6368      +20     
+ Misses       2654     2649       -5     
  Partials      558      558              
Impacted Files Coverage Δ
database/user.go 67.06% <100.00%> (ø)
service/user.go 91.66% <100.00%> (+13.61%) ⬆️
service/userdata.go 75.67% <100.00%> (+6.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonas-plum jonas-plum merged commit aee0be7 into main Feb 5, 2023
@jonas-plum jonas-plum deleted the mail-usernames branch February 5, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'unique constraint violated' when using email as preferred username claim with Google OIDC
3 participants