Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Securrency-OSS/mirai#191 - 🚀 Added support for align widget #226

Merged

Conversation

loud-at-heart
Copy link
Contributor

@loud-at-heart loud-at-heart commented Oct 13, 2023

Description

To add align support for Mirai

Related Issues

Closes #191

Type of Change

Added parser for Align widget

  • New feature (non-breaking change which adds functionality)

@divyanshub024
Copy link
Member

@loud-at-heart Thank you for the PR. 🚀
Can you please add the align widget example in Mirai Gallery? And please the PR checks, it's failing.

[mirai]:    info - lib/src/framework/mirai.dart:11:8 - The import of 'package:mirai/src/parsers/mirai_align/mirai_align.dart' is unnecessary because all of the used elements are also provided by the import of 'package:mirai/src/parsers/parsers.dart'. Try removing the import directive. - unnecessary_import

@loud-at-heart
Copy link
Contributor Author

loud-at-heart commented Oct 13, 2023

@loud-at-heart Thank you for the PR. 🚀 Can you please add the align widget example in Mirai Gallery? And please the PR checks, it's failing.

[mirai]:    info - lib/src/framework/mirai.dart:11:8 - The import of 'package:mirai/src/parsers/mirai_align/mirai_align.dart' is unnecessary because all of the used elements are also provided by the import of 'package:mirai/src/parsers/parsers.dart'. Try removing the import directive. - unnecessary_import

Do you need a seperate tile or adding it on container will work?

@divyanshub024
Copy link
Member

@loud-at-heart This looks good!!

@loud-at-heart
Copy link
Contributor Author

@loud-at-heart This looks good!!

I added a separate tile too for align..

@divyanshub024
Copy link
Member

@loud-at-heart I think you forgot to export the MiraiAlign in parsers.dart

@loud-at-heart
Copy link
Contributor Author

MiraiAlign

Sure making the change

@divyanshub024
Copy link
Member

Thank you for this PR @loud-at-heart
We are grateful for your contribution 🤩

@divyanshub024 divyanshub024 merged commit 87c0d79 into Securrency-OSS:main Oct 13, 2023
3 checks passed
@divyanshub024 divyanshub024 added this to the v0.6 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add align widget
2 participants