Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use app theme colors in color property #246

Merged
merged 5 commits into from
Feb 6, 2024
Merged

feat: Use app theme colors in color property #246

merged 5 commits into from
Feb 6, 2024

Conversation

i-asimkhan
Copy link
Contributor

@i-asimkhan i-asimkhan commented Jan 23, 2024 •
edited

Description

Added ability to accept theme color values in color property of mirai widgets.

To test please use like this,

 "color": "primary",

Related Issues

#242

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@i-asimkhan i-asimkhan linked an issue Jan 23, 2024 that may be closed by this pull request
feat: Allow users to call theme styles in json #242
Closed
@i-asimkhan i-asimkhan self-assigned this Jan 26, 2024
@divyanshub024 divyanshub024 added this to the v0.6 milestone Jan 26, 2024
@divyanshub024 divyanshub024 merged commit 4f83b7d into main Feb 6, 2024
3 checks passed
@divyanshub024 divyanshub024 deleted the asim/theme-color-names branch February 6, 2024 12:26
@divyanshub024 divyanshub024 changed the title feat: Added ability to accept theme color values in color property of mirai widgets. feat: Use app theme colors in color property Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshub024 divyanshub024 divyanshub024 approved these changes

Assignees

@i-asimkhan i-asimkhan

Labels
None yet
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

feat: Allow users to call theme styles in json
2 participants
@i-asimkhan @divyanshub024