updates consultant roles #2818
Closed
updates consultant roles #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonF
reviewed
Jul 13, 2023
src/components/authorization/policies/by-role/consultant-manager.policy.ts
Outdated
Show resolved
Hide resolved
src/components/authorization/policies/by-role/consultant-manager.policy.ts
Outdated
Show resolved
Hide resolved
CarsonF
reviewed
Jul 14, 2023
src/components/authorization/policies/by-role/consultant.policy.ts
Outdated
Show resolved
Hide resolved
src/components/authorization/policies/by-role/consultant-manager.policy.ts
Outdated
Show resolved
Hide resolved
CarsonF
reviewed
Jul 14, 2023
|
I think this has it all squared away now. Consultant + Consultant manager can see progress reports including the team updates, story and progress as members of a project Consultant manager can see any of these things for any Low or Medium sensitivity projects |
CarsonF
requested changes
Aug 1, 2023
Comment on lines
+25
to
+31
| r.ProgressReport.when(member).read.children((c) => | ||
| [c.teamNews, c.communityStories, c.highlights].flatMap((it) => it.read), | ||
| ), | ||
| r.ProgressReportVarianceExplanation.when(member).read, | ||
| r.ProgressReportTeamNews.read.specifically((p) => p.responses.read), | ||
| r.ProgressReportCommunityStory.read.specifically((p) => p.responses.read), | ||
| r.ProgressReportHighlight.read.specifically((p) => p.responses.read), |
There was a problem hiding this comment.
I believe what we want here is
[
r.ProgressReportCommunityStory,
r.ProgressReportHighlight,
r.ProgressReportTeamNews,
r.ProgressReportVarianceExplanation,
].flatMap((it) => it.when(member).read),Your lines 26 is trying to be the same thing as 29-31. So we don't need both, and we prefer the non-children syntax for static parent cases.
The other difference is that 29-31 allows reading globally, instead of only if a member. Which I don't think is the intent.
Also I know we talked before about this, but the
.specifically((p) => p.responses.read),shouldn't be needed as it's the same action permission as what the object level has.
|
Fixed here: #2853 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Monday item by Unito
PR for 4558680508