-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EdgeDB] Add Engagement
queries | refactor service/repo layers appropriately
#3219
Open
bryanjnelson
wants to merge
22
commits into
develop
Choose a base branch
from
0945-engagement-queries
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79d9f5c
to
b825320
Compare
acee2b1
to
a6f0625
Compare
🗞 GraphQL SummaryView schema changes@@ -1449,10 +1449,10 @@
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
modifiedAt: DateTime!
parent: Project!
project: Project!
@@ -1462,9 +1462,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
input EngagementFilters {
"""Only engagements matching this type"""
@@ -2081,10 +2081,10 @@
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
intern: SecuredUser!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
mentor: SecuredUser!
methodologies: SecuredMethodologies!
modifiedAt: DateTime!
parent: InternshipProject!
@@ -2097,9 +2097,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
enum InternshipPosition {
Administration
@@ -2381,16 +2381,16 @@
disbursementCompleteDate: SecuredDateNullable!
endDate: SecuredDateNullable!
endDateOverride: SecuredDateNullable!
firstScripture: SecuredBoolean!
- historicGoal: SecuredString!
+ historicGoal: SecuredStringNullable!
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
language: SecuredLanguage!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
"""The latest progress report that has a report submitted"""
latestProgressReportSubmitted: SecuredPeriodicReport!
lukePartnership: SecuredBoolean!
@@ -2400,9 +2400,9 @@
The progress report due next. This is the period currently in progress.
"""
nextProgressReportDue: SecuredProgressReport!
openToInvestorVisit: SecuredBoolean!
- paratextRegistryId: SecuredString!
+ paratextRegistryId: SecuredStringNullable!
parent: TranslationProject!
"""
A list of mediums used across all of the engagement's products and their
@@ -2424,9 +2424,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
type LanguageEngagementListOutput implements PaginatedList {
"""Whether the next page exists"""
🚨 Breaking Changes
|
9760564
to
f1cd194
Compare
f1cd194
to
6bb145c
Compare
c6b1095
to
069b763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday task
Description
Engagement
functionality to prepare for EdgeDB migrationEngagement
repositoryReady for review checklist
[N/A]
Add/update tests if needed