Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeDB] Add Engagement queries | refactor service/repo layers appropriately #3219

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

bryanjnelson
Copy link
Contributor

@bryanjnelson bryanjnelson commented May 29, 2024

Monday task

Description

  • Refactor Engagement functionality to prepare for EdgeDB migration
  • Create EdgeDB Engagement repository

Ready for review checklist

Use [N/A] if the item is not applicable to this PR or remove the item

  • Change the task url above to the actual Monday task
  • [N/A] Add/update tests if needed
  • Add reviewers to this PR

@bryanjnelson bryanjnelson force-pushed the 0945-engagement-queries branch 5 times, most recently from 79d9f5c to b825320 Compare June 6, 2024 21:26
@bryanjnelson bryanjnelson force-pushed the 0945-engagement-queries branch 2 times, most recently from acee2b1 to a6f0625 Compare June 7, 2024 17:27
Copy link

github-actions bot commented Jun 7, 2024

🗞 GraphQL Summary

View schema changes
@@ -1449,10 +1449,10 @@
 
   """The object's ID"""
   id: ID!
   initialEndDate: SecuredDateNullable!
-  lastReactivatedAt: SecuredDateTime!
-  lastSuspendedAt: SecuredDateTime!
+  lastReactivatedAt: SecuredDateTimeNullable!
+  lastSuspendedAt: SecuredDateTimeNullable!
   modifiedAt: DateTime!
   parent: Project!
   project: Project!
 
@@ -1462,9 +1462,9 @@
   startDateOverride: SecuredDateNullable!
   status: SecuredEngagementStatus!
 
   """The last time the engagement status was modified"""
-  statusModifiedAt: SecuredDateTime!
+  statusModifiedAt: SecuredDateTimeNullable!
 }
 
 input EngagementFilters {
   """Only engagements matching this type"""
@@ -2081,10 +2081,10 @@
   """The object's ID"""
   id: ID!
   initialEndDate: SecuredDateNullable!
   intern: SecuredUser!
-  lastReactivatedAt: SecuredDateTime!
-  lastSuspendedAt: SecuredDateTime!
+  lastReactivatedAt: SecuredDateTimeNullable!
+  lastSuspendedAt: SecuredDateTimeNullable!
   mentor: SecuredUser!
   methodologies: SecuredMethodologies!
   modifiedAt: DateTime!
   parent: InternshipProject!
@@ -2097,9 +2097,9 @@
   startDateOverride: SecuredDateNullable!
   status: SecuredEngagementStatus!
 
   """The last time the engagement status was modified"""
-  statusModifiedAt: SecuredDateTime!
+  statusModifiedAt: SecuredDateTimeNullable!
 }
 
 enum InternshipPosition {
   Administration
@@ -2381,16 +2381,16 @@
   disbursementCompleteDate: SecuredDateNullable!
   endDate: SecuredDateNullable!
   endDateOverride: SecuredDateNullable!
   firstScripture: SecuredBoolean!
-  historicGoal: SecuredString!
+  historicGoal: SecuredStringNullable!
 
   """The object's ID"""
   id: ID!
   initialEndDate: SecuredDateNullable!
   language: SecuredLanguage!
-  lastReactivatedAt: SecuredDateTime!
-  lastSuspendedAt: SecuredDateTime!
+  lastReactivatedAt: SecuredDateTimeNullable!
+  lastSuspendedAt: SecuredDateTimeNullable!
 
   """The latest progress report that has a report submitted"""
   latestProgressReportSubmitted: SecuredPeriodicReport!
   lukePartnership: SecuredBoolean!
@@ -2400,9 +2400,9 @@
   The progress report due next. This is the period currently in progress.
   """
   nextProgressReportDue: SecuredProgressReport!
   openToInvestorVisit: SecuredBoolean!
-  paratextRegistryId: SecuredString!
+  paratextRegistryId: SecuredStringNullable!
   parent: TranslationProject!
 
   """
   A list of mediums used across all of the engagement's products and their
@@ -2424,9 +2424,9 @@
   startDateOverride: SecuredDateNullable!
   status: SecuredEngagementStatus!
 
   """The last time the engagement status was modified"""
-  statusModifiedAt: SecuredDateTime!
+  statusModifiedAt: SecuredDateTimeNullable!
 }
 
 type LanguageEngagementListOutput implements PaginatedList {
   """Whether the next page exists"""

🚨 Breaking Changes

  • Engagement.lastReactivatedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • Engagement.lastSuspendedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • Engagement.statusModifiedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • InternshipEngagement.lastReactivatedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • InternshipEngagement.lastSuspendedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • InternshipEngagement.statusModifiedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • LanguageEngagement.historicGoal changed type from SecuredString! to SecuredStringNullable!.
  • LanguageEngagement.lastReactivatedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • LanguageEngagement.lastSuspendedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.
  • LanguageEngagement.paratextRegistryId changed type from SecuredString! to SecuredStringNullable!.
  • LanguageEngagement.statusModifiedAt changed type from SecuredDateTime! to SecuredDateTimeNullable!.

@bryanjnelson bryanjnelson marked this pull request as ready for review June 11, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants