Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for Update Language #3239

Closed
wants to merge 1 commit into from
Closed

Bugfix for Update Language #3239

wants to merge 1 commit into from

Conversation

atGit2021
Copy link
Contributor

@atGit2021 atGit2021 commented Jun 13, 2024 •
edited
Loading

@atGit2021 atGit2021 self-assigned this Jun 13, 2024
@atGit2021 atGit2021 requested a review from CarsonF as a code owner June 13, 2024 23:47
@atGit2021
Copy link
Contributor Author

I think I'll need to add a check for an empty object for simpleChanges too, but will wait for your initial feedback

CarsonF
CarsonF reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear change anything logically.
What error are you trying to fix?
How does this change that error?

@CarsonF CarsonF closed this Jun 14, 2024
@CarsonF CarsonF deleted the 1190-updateLanguage-BugFix branch June 14, 2024 20:36
@CarsonF
Copy link
Member

CarsonF commented Jun 14, 2024

Real fix: SeedCompany/cord-field#1541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonF CarsonF CarsonF left review comments

@bryanjnelson bryanjnelson Awaiting requested review from bryanjnelson

Assignees

@atGit2021 atGit2021

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atGit2021 @CarsonF