Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText via Editor.js #1150

Closed
CarsonF opened this issue Jul 27, 2022 · 2 comments · Fixed by #1181 · May be fixed by #1166
Closed

RichText via Editor.js #1150

CarsonF opened this issue Jul 27, 2022 · 2 comments · Fixed by #1181 · May be fixed by #1166
Assignees
@andrewmurraydavid

Comments

@CarsonF
Copy link
Member

CarsonF commented Jul 27, 2022 •
edited by sync-by-unito bot
Loading

I want to integrate with https://editorjs.io/.

How does rendering work? Can each block type use a customized component that fits our style?
It's possible to render differently for view vs edit. Edit gets the full editor, but view just renders the markup. Sounds more performant.

https://github.com/editor-js/awesome-editorjs
https://github.com/Jungwoo-An/react-editor-js
https://github.com/moveyourdigital/editorjs-blocks-react-renderer

┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466492736
@CarsonF CarsonF self-assigned this Jul 27, 2022
@CarsonF CarsonF assigned andrewmurraydavid and unassigned CarsonF Sep 23, 2022
@CarsonF
Copy link
Member Author

CarsonF commented Sep 23, 2022

It's possible we still use our own components with the real editor too.
https://walkthrough.so/pblc/QCawSCKwOQLn/creating-a-custom-editorjs-block-tool-with-react?sn=3
Even for headers/body maybe.

@andrewmurraydavid andrewmurraydavid linked a pull request Oct 3, 2022 that will close this issue
Comments functionality #1166
Open
@andrewmurraydavid andrewmurraydavid mentioned this issue Oct 14, 2022
Merged
@andrewmurraydavid andrewmurraydavid linked a pull request Nov 3, 2022 that will close this issue
Rich Text Field/View #1181
Merged
@CarsonF
Copy link
Member Author

CarsonF commented Nov 21, 2022

Implemented in #1181

@CarsonF CarsonF closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewmurraydavid andrewmurraydavid

Labels
None yet
Projects
CORD
Status: Sprint Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rich Text Field/View SeedCompany/cord-field
Comments functionality SeedCompany/cord-field
2 participants
@CarsonF @andrewmurraydavid