Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow users to upload a planning file when there are no products #1125

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

elisabeth-sorrell
Copy link
Collaborator

@elisabeth-sorrell elisabeth-sorrell commented May 19, 2022

Closes #1092

┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466497735

@elisabeth-sorrell
Copy link
Collaborator Author

No products created:
Screen Shot 2022-05-19 at 3 24 58 PM

After a product is created
Screen Shot 2022-05-19 at 3 27 12 PM

Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close, @elisabeth-sorrell, but I think there was a misunderstood requirement here. And I'll take that upon myself for not being clear enough in the issue. ☹️

You wrote the case that won't allow a Planning Spreadsheet upload if the Goals are 0. However, that case is okay...one of the ways that the user will get Goals into Cord is through a PnP Planning Spreadsheet upload.

What we want to do here is not allow a Progress Report upload (Progress Tab of the PnP) if the Goals are 0. This will force them to either a) add a goal manually through the UI or upload a Planning Spreadsheet.

1. Do not display the NewVersion button for each report row
2. show a 'You are not allowed to...' card in the specific progress report
3. Disable the 'Upload' button for the Progress report overiew card in the engagment details
Also, take out the logic for disabling the Planning file. That can extract and create goals, so we don't want to disable that.
@elisabeth-sorrell
Copy link
Collaborator Author

Okay, I have this:

  1. The 'Upload Report' button is disabled. I was thinking of just making it disappear but thought that it might be a little confusing. This way clues in the users that something's up.

Screen Shot 2022-05-27 at 4 19 43 PM

  1. There is no "New Version" button for each report row, so it's not an option to upload a new version of report as a shortcut when there are no products

Screen Shot 2022-05-27 at 4 21 18 PM

  1. There is a disabled card explaining that a planning info file cannot be uploaded unless there's at least one goal/product

Screen Shot 2022-05-27 at 4 22 30 PM

Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm not familiar enough with the UI Code to approve anything I'll let that piece up to Carson. However, I agree that disabling the button instead of removing it is better. And the disabled card verbiage make sense. I'm not sure about the removal of the "New Version" option; I'll let @CarsonF chime in on that.

@bryanjnelson
Copy link
Contributor

But it looks good...thanks @elisabeth-sorrell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Progress Report from being uploaded before a Planning Spreadsheet exists
2 participants