Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error when creating the product #1126

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

elisabeth-sorrell
Copy link
Collaborator

@elisabeth-sorrell elisabeth-sorrell commented May 19, 2022

Closes #966

┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466497337

@elisabeth-sorrell
Copy link
Collaborator Author

elisabeth-sorrell commented May 20, 2022

I personally don't really like keeping the breadcrumb, so I can take that out too if you agree.

Screen Shot 2022-05-19 at 6 54 57 PM

Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't really like keeping the breadcrumb, so I can take that out too if you agree.

Normally I'd say we should try to be consistent with layout. If it's not pulsing, I'd say it's fine.

src/scenes/Products/Create/CreateProduct.tsx Outdated Show resolved Hide resolved
@elisabeth-sorrell
Copy link
Collaborator Author

I personally don't really like keeping the breadcrumb, so I can take that out too if you agree.

Normally I'd say we should try to be consistent with layout. If it's not pulsing, I'd say it's fine.

Took a look to check and it is pulsing. What do we usually do for this kind of situation in field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Product page doesn't show error
2 participants