Mobile view main nav #1394
Closed
Mobile view main nav #1394
+338
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdch
force-pushed
the
mobile-view-mian-nav
branch
from
124a75b
to
eff997f
Compare
Renamed ResponsiveHeader to MobileNavbar. Updated Menu label to be dynamic to what view is active. updated reference to MobileNavbar in MainLayout.tsx Removed hello text, bell icon and upload manager link removed callapsing functionality from the search bar made the search bar collapse or expand when clicking on search icon, still needs a little work though to smooth it out updated ProfileToolbar to conditionally render based on mobile view or standard view cleaned up the file and move some functionality to another component updated to use useMediaQuery to get the winodw size instead of the custome hook I createdg updated styling for monile view of search bar wrapped the ResponsiveHeader with the CreateDialogProviders so the modals will work when creating new items renamed currentWindowSize to useIsMobile and moved it to the hooks folder removed some commented out code that was not needed Added the drawer functionality and navigation elements created component to check current screensize and decluttered other files
added sidebar color in pallet added mobile breakpoint no need for useIsMobile cleaned up Sidebar updated Header to use css breakpoints updated HeaderSearch to use css breakpoints updated ProfileToolbar to use css breakpoints extending sx on AppBar instead of Container
andrewmurraydavid
force-pushed
the
mobile-view-mian-nav
branch
from
9bfa739
to
24cacd1
Compare
Renamed ResponsiveHeader to MobileNavbar. Updated Menu label to be dynamic to what view is active. updated reference to MobileNavbar in MainLayout.tsx Removed hello text, bell icon and upload manager link removed callapsing functionality from the search bar made the search bar collapse or expand when clicking on search icon, still needs a little work though to smooth it out updated ProfileToolbar to conditionally render based on mobile view or standard view cleaned up the file and move some functionality to another component updated to use useMediaQuery to get the winodw size instead of the custome hook I createdg updated styling for monile view of search bar wrapped the ResponsiveHeader with the CreateDialogProviders so the modals will work when creating new items renamed currentWindowSize to useIsMobile and moved it to the hooks folder removed some commented out code that was not needed Added the drawer functionality and navigation elements created component to check current screensize and decluttered other files
added sidebar color in pallet added mobile breakpoint no need for useIsMobile cleaned up Sidebar updated Header to use css breakpoints updated HeaderSearch to use css breakpoints updated ProfileToolbar to use css breakpoints extending sx on AppBar instead of Container
andrewmurraydavid
force-pushed
the
mobile-view-mian-nav
branch
from
24cacd1
to
6dc911f
Compare
andrewmurraydavid
force-pushed
the
mobile-view-mian-nav
branch
from
cbcd9bb
to
114d852
Compare
cleaned up sx on ProfileToolbar
andrewmurraydavid
force-pushed
the
mobile-view-mian-nav
branch
from
38b6834
to
8e0c8e4
Compare
| </> | ||
| ); | ||
|
|
||
| export const getActiveItemLabel = () => { |
There was a problem hiding this comment.
@CarsonF should I rename this to getActiveNavItemLabel or is this descriptive enough?
willdch
commented
Mar 8, 2023
willdch
commented
Mar 9, 2023
andrewmurraydavid
force-pushed
the
mobile-view-mian-nav
branch
from
e359eeb
to
81c1bf7
Compare
andrewmurraydavid
added
preview-it
|
This lived to the end of its lifetime and died |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday.com ticket
My stab at making the main nav mobile friendly.