Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated MarketingLocation button to marketingCountry and added marketingRegion button #1514

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Updated MarketingLocation button to marketingCountry and added marketingRegion button #1514

wants to merge 4 commits into from

Conversation

willdch
Copy link
Contributor

@willdch willdch commented Jan 24, 2024 •
edited by sethmcknight
Loading

@willdch willdch self-assigned this Jan 24, 2024
@willdch willdch marked this pull request as ready for review February 7, 2024 15:55
@willdch willdch requested a review from CarsonF as a code owner February 7, 2024 15:55
andrewmurraydavid
andrewmurraydavid requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@andrewmurraydavid andrewmurraydavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some good progress! I left a few comments. Let me know if you've got questions!

src/scenes/Projects/Overview/ProjectOverview.graphql Outdated Show resolved Hide resolved
src/scenes/Projects/Overview/ProjectOverview.graphql Outdated Show resolved Hide resolved
src/scenes/Projects/Overview/ProjectOverview.graphql Outdated Show resolved Hide resolved
src/components/InternshipEngagementListItemCard/InternshipEngagementListItem.graphql Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonF CarsonF Awaiting requested review from CarsonF CarsonF is a code owner

@andrewmurraydavid andrewmurraydavid Awaiting requested review from andrewmurraydavid

Requested changes must be addressed to merge this pull request.

Assignees

@willdch willdch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willdch @andrewmurraydavid