-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Prevent SettingsQR from trying to enable Persistent Settings when SD card is not inserted #464
Conversation
As of a48620f ACK tested It's nice having the separate confirmation screens that say exactly where settings are. Tested on pi2 Raspi-os and pi0 seedsigner-os, all tests passing too. |
All credit goes to you on this one, @jdlcdl! You found the bug AND figured out the cause that was totally eluding me. |
In case it helps: I've resolved this conflict locally by keeping most changes for both pr_464 and latest dev, in two separate sections of ./tests/screenshot_generator/generator.py with all tests passing and 6 additional successful screenshots bringing total number to 100.
|
* Move SettingsQR confirmation screen out of scan_screens.py
a48620f
to
d810d12
Compare
as of rebased d810d12 ACK tested. on pi0 w/ hash 2b76dd99f767efb22472cca7f8d29fb254dba7e6ea682843342822d5db7f0fb3 |
ACK and tested |
fixes #457
The problem
If you remove the SD card and then scan in a SettingsQR that attempts to enable Persistent Settings, you get a System Error exception.
The fix
Additional changes
MicroSD
class so that individual tests can run scenarios with varyingMicroSD.is_inserted
states. Instead of the original class'is_inserted
property, we just provide it as an exposed class var that any test can directly alter as needed. The setup for each test automatically resets it to True (seeBaseTest.setup_method()
).SettingsUpdatedScreen
out of scan_screens.py and renamed into settings_screens.py.TestSettings
that omittedsuper().setup_class()
. Had no effect before, but runs into problems with the updates inBaseTest
in this PR without it.