Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28 Use "Tag list" along with "sidecar files as tags for each image" #30

Merged
merged 2 commits into from
Dec 25, 2019

Conversation

Seedmanc
Copy link
Owner

add manually entered tags to sidecar ones

js/uploader.js Outdated Show resolved Hide resolved
@ProximaNova
Copy link
Collaborator

ProximaNova commented Dec 15, 2019

I updated my fork to be up to date with your version. I then updates uploader.js with the above change. I redirected the appropriate URLs to URLs of my fork. (Check my updates if you think I messed up.) Unless GitHub takes a long time to realize my updates, it didn't work. "use sidecar files" along with "Tag list": "Tag list" is still greyed out.

2019-12-15 01:05:39 UTC - finished updating my fork.
2019-12-15 01:11:## UTC - uploaded 5 files (each with a sidecar .txt file):
[...]:11] Started uploading 5 files.
[...]:11] Image file1.jpeg was successfully uploaded.
[...]:11] Image file2.png was successfully uploaded.
[...]:11] Image file3.jpeg was successfully uploaded.
[...]:11] Image file4.png was successfully uploaded.
[...]:11] Image file5.png was successfully uploaded.
[...]:11] Finished uploading; 5 uploaded ok + 0 failed = 5 images total.

None of the sidecar files worked. Also, I made some bug reports yesterday; I think that it worked fine a month or multiple months ago, and by "it" I mean sidecar files were uploaded as tags for the image.

Seedmanc added a commit that referenced this pull request Dec 17, 2019
Seedmanc added a commit that referenced this pull request Dec 17, 2019
@Seedmanc
Copy link
Owner Author

Fixed, this should work.

@ProximaNova
Copy link
Collaborator

ProximaNova commented Dec 20, 2019

Just read #30 (comment) - I will test on Firefox and Google Chrome tomorrow.

I think you might have asked if sidecar files not working was an inconvenience in the past. I'd say that it is a big inconvenience the following took me like 30 minutes to 50 minutes. I had to see if it would work with a different browser, so I installed the malware known as Google Chrome. I couldn't install Google Chrome to the directory that I wanted. Therefore, I followed this guide: https://smallbusiness.chron.com/change-installation-path-google-chrome-42689.html which is missing these commands (if they want to get users to save C:\ disk space, approx. 500 MB) which must have CMD ran as admin:
junction "C:\Program Files (x86)\Google\Chrome" "D:\user\Documents\ChromeSucks\ProgramFilesx86\Chrome"
junction "C:\Program Files (x86)\Google\CrashReports" "D:\user\Documents\ChromeSucks\ProgramFilesx86\CrashReports"
junction "C:\Program Files (x86)\Google\Policies" "D:\user\Documents\ChromeSucks\ProgramFilesx86\Policies"
junction "C:\Program Files (x86)\Google\Temp" "D:\user\Documents\ChromeSucks\ProgramFilesx86\Temp"
junction "C:\Program Files (x86)\Google\Update" "D:\user\Documents\ChromeSucks\ProgramFilesx86\Update"

resulted in "Egads! Installation failed. Error code: 0x80070003." It made me uninstall then reinstall Google Chrome, and when I uninstalled it it asked that I fill out then submit a web page about why I uninstalled it. I told them I couldn't install it where I wanted to, that I didn't plan on reinstalling it, and that I would NOT recommend Chrome to friends and/or family. I guess Google didn't like my review because when I went to https://www.google.com/ it was the Swedish version of Google. I searched around with Google and looked at various parts of the google.com website for a while; I found that it could tell from my IP address that I am in the United States but it still gave me Swedish cuck shit:
sv (text I got): "[ZIP code], [city in a state in the USA] - Från din IP-adress - Använd exakt plats - Läs mer"
en (translation): "[ZIP code], [city in a state in the USA] - From your Internet address - Use precise location"

Why was I suddenly using swedish Google? I don't think I accidentally clicked anything. That was weird.

@Seedmanc
Copy link
Owner Author

Sorry if it's causing you trouble. This is why I made the /dev directory, where one can try and do some tests without affecting the working deployment, only need to point the scripts to that directory instead of the main one.

Usually the branches are used for that, however, AFAIK there's only one branch available for github-pages, that enables the online functionality, so we have to make workarounds.

@ProximaNova
Copy link
Collaborator

ProximaNova commented Dec 24, 2019

7288ed0 fixed it, thanks! It works with Firefox 71.0 (64-bit); for example, it works with https://danbooru.donmai.us. I didn't test it with Google Chrome because it is not free open source software. Elitists/anime snobs might call this "prospecting", but you can find a lot of high quality anime images at https://ii.booru.org/index.php?page=post&s=list which are not at danbooru.donmai.us if you need to test the functionality with Danbooru websites. See if the image is already there with http://iqdb.org/.

@Seedmanc Seedmanc merged commit 41ade11 into gh-pages Dec 25, 2019
@Seedmanc Seedmanc deleted the Seedmanc-patch-#28 branch December 25, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants