Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove padding constant #2

Closed
b95505017 opened this issue Oct 23, 2014 · 1 comment
Closed

remove padding constant #2

b95505017 opened this issue Oct 23, 2014 · 1 comment
Assignees

Comments

@b95505017
Copy link

float outerRadius = ((size / 2) * 0.75f) * 0.937f;
float innerRadius = ((size / 2) * 0.75f) * 0.75f;

I think that some constants such as 0.75f could remove.
Let user control the paddings within bounds.

@Sefford Sefford self-assigned this Oct 24, 2014
@Sefford
Copy link
Owner

Sefford commented Oct 24, 2014

You're right.

I have modified a little the behavior of the drawable. Now the ImageView size + padding is what decides the size of the outer ring, and you can control the size of the inner circle by using circleScale.

The difference is that now circleScale = 1.0 = outerRing Radius. I have incorporated also a Builder for the CircleProgressDrawable, as the constructor signature was starting to be too long and complex.

1.3 version with these changes is already available on Maven Central repo.

Thanks for the feedback! :)

@Sefford Sefford closed this as completed Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants