Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]Support for Item Stacking Plugins #11

Closed
Azakaturan opened this issue May 28, 2021 · 5 comments
Closed

[Suggestion]Support for Item Stacking Plugins #11

Azakaturan opened this issue May 28, 2021 · 5 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@Azakaturan
Copy link

What would you like added to DankTech?
Support for item stacks above the default of 64. The reason being, if there are more than the default 64 on the ground, anything extra that is picked up is voided.
Does not having this cause an issue?
Yes, as many servers have addons such as WildStacker to increase item stack sizes in order to reduce server lag.

@Sefiraat
Copy link
Owner

We did test with item stacks over 64 and found it sucessful.

Can you let me know what stacking plugin you are using specifically so i can test and potentially add support?

Thanks

@Azakaturan
Copy link
Author

Azakaturan commented May 29, 2021

I'm using WildStacker if you want to test it.

image
image
image

Just added a few images to show what I mean.

@Sefiraat Sefiraat self-assigned this May 29, 2021
@Sefiraat Sefiraat added this to In progress in Todo May 29, 2021
@Sefiraat
Copy link
Owner

I have added support for WildStacker. It's quite satisfying to do /give @A stone 500000 and watching it enter the pack within a second (do not recommend on production servers though of course!)

This has been shipped in 1.2.6 which is ready for download.

Thanks for the feedback, any more suggestions are more than welcomed.

@Azakaturan
Copy link
Author

I put in version 1.2.6 but it looks like it's still only adding max 64 of the item, and I'm not really sure why.

@Sefiraat
Copy link
Owner

Is this on a public server? If you drop me the IP I can swing by and take a look. Otherwise if you have discord DM me: thepog1#3526

Do you have another plugins that might interact with item pickup?

@Sefiraat Sefiraat reopened this May 29, 2021
@Sefiraat Sefiraat added bug Something isn't working and removed Suggestion labels May 29, 2021
Sefiraat pushed a commit that referenced this issue May 30, 2021
WildStacker taken out of enable, sorts load order issue
Minor test formatting change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Todo
In progress
Development

No branches or pull requests

2 participants