Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable window length #48

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Variable window length #48

merged 9 commits into from
Mar 29, 2024

Commits on Mar 29, 2024

  1. Constrain end time of P and S windows to end time of waveform data. 

    Ensure noise window has same length as signal (P or S) window.
    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b7bad78 View commit details
    Browse the repository at this point in the history

  2. Take into account signal_pre_time for definition of noise window in _… 

    …define_signal_and_noise_windows function.
    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ee36e4b View commit details
    Browse the repository at this point in the history

  3. Set noise_pre_time to noise window length if it is None

    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    30611d7 View commit details
    Browse the repository at this point in the history

  4. Added support for variable window length: 

    - Added variable_win_length_factor configuration parameter
  in configspec.conf
- Updated `ssp_process_traces._define_signal_and_noise_windows()`
  to take into account variable_window_length_factor
- Fixed `ssp_plot_traces._trim_traces()` to trim plotted trace to
  real start of noise window and real end of S window
  (plus some margin).
    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    50632a6 View commit details
    Browse the repository at this point in the history

  5. Prevent trailing newline in ssp_plot_spectra._params_text 

    If Er could not be computed, which may result in obscure matplotlib error.
    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9833227 View commit details
    Browse the repository at this point in the history

  6. Log variable window length

    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    72652cc View commit details
    Browse the repository at this point in the history

  7. Do not warn if noise window ends at start of P window 

    Also: improved warning message
    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    76cf8e0 View commit details
    Browse the repository at this point in the history

  8. Make sure that noise window does not end at the P arrival time 

    But only in case when the noise window length is not specified.
This ensures backward compatibility with the old behavior.
    @claudiodsf
    claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8a6d760 View commit details
    Browse the repository at this point in the history

  9. Added variable window lengths to CHANGELOG

    @krisvanneste @claudiodsf
    krisvanneste authored and claudiodsf committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    f6a233b View commit details
    Browse the repository at this point in the history