Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Fix docker build and run stages #3

Merged
merged 3 commits into from Jan 2, 2020
Merged

Fix docker build and run stages #3

merged 3 commits into from Jan 2, 2020

Commits on Jan 2, 2020

  1. fix(docker): Move from CMD and ENTRYPOINT to RUN for build stages 

    Using RUN is required to exit non-zero during both a `docker build`
command with `--target` stage not defined, and with a `docker run`
that uses an already-built image (See `Makefile` and `Dockerfile`)
    @JonZeolla
    JonZeolla committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    9d79c7e View commit details
    Browse the repository at this point in the history

  2. fix(docker): Ensure docker run and build exit on stage failures 

    Using RUN is required to exit non-zero during both a `docker build`
command with `--target` stage not defined, and with a `docker run` that
uses an already-built image (See `Makefile` and `Dockerfile`)

Also, move to a cleaner approach to sharing information from arguments
across a multi-stage docker build, based on
moby/moby#37345 (comment)
    @JonZeolla
    JonZeolla committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    4ee7033 View commit details
    Browse the repository at this point in the history

  3. docs: update reports 

    Update the reports/ folder via `make report`
    @JonZeolla
    JonZeolla committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    83acbb1 View commit details
    Browse the repository at this point in the history