Create a python package of flexmeasures-entsoe #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Great, I tested installing locally and importing just via the name flexmeasures_entsoe.
I added two small improvements in the Readme myself.
For the detailled&pinned requirements (.txt), I wonder if they are needed. This is always going to be installed in addition to FlexMeasures, so I'd always use the .in versions. I'd otherwise easily run into clashed between the installed dependencies for FlexMeasures and the ones for the plugin. What do you think?
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
|
Should I merge this PR? |
|
We still need to decide on getting rid of the pinned dependencies (.txt). See my comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have tried to create a pip installable package of our entsoe plugin. I have also removed the unused python modules, and solved the mypy issue.