Forecasts limited to registered sensors #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahmad-Wahid
changed the title
Ahmad-Wahid
changed the title
* change owm version to 3 and add version checker * rais a warning * try black only * make API_VERSION a module constant and add tested versions to the warning Signed-off-by: Nicolas Höning <nicolas@seita.nl> --------- Signed-off-by: Nicolas Höning <nicolas@seita.nl> Co-authored-by: Nicolas Höning <nicolas@seita.nl>
nhoening
requested changes
Jul 21, 2023
…ich-are-present' into 11-save-data-for-those-sensor-which-are-present
nhoening
requested changes
Jul 25, 2023
There was a problem hiding this comment.
This is a little mit more tricky than I had thought, but we're getting closer :)
I even made two new tickets while thinking about this PR.
Here is one other comment I have - an different improvement I saw while looking at the code:
The line owm.py:107 (data_source = get_or_create_owm_data_source()) can move one upwards, outside of the for-loop (we use the same data source for all sensors).
nhoening
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our focus was on
mappingall the available sensors, but this approach restricted us to obtaining forecasts for just one or two sensors. In this pull request (PR), I've implemented a sensor check. This means that if a sensor is not registered, it will be disregarded during the forecasting process.