New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pandas 2 #131
Support Pandas 2 #131
Conversation
Good to know: our main test suite doesn't rely on |
Any tips on reviewing this? |
No tips really. I was happy to have our tests pass. Let me know if I need to check against breaking changes explicitly. |
Which tests? Only the ones here, or also FlexMeasures? |
Maybe we can use this PR to update the Python version we support, as well? This is the highest:
But I guess 3.10 or even 3.11 are also supported. |
Just the ones here. FlexMeasures still needs some attention, but that's a separate issue (and different repo), right? |
We test 3.10, but not 3.11. So I think I'd just add 3.10 for now. |
Well it would add confidence here. But of course if it requires more work there, we need to see how we can manage. |
I tried it out (FM with Pandas 2), and found 1 more issue that timely-beliefs tests should have caught. I'll expand the test suite accordingly, and implement a fix (or workaround, because I believe it might be a regression in Pandas). |
You will do that here in this PR right? |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
It turned out that the DataFrame constructor still needs to call It is only the Series constructor that can no longer call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have one question.
Signed-off-by: F.N. Claessen <felix@seita.nl>
This should get us ready for upgrading to Pandas 2.
The good people of
sktime
are still working on compatibility with Pandas 2. Their latest release (0.17.1) already resolves any problems caught by our tests, but theirpyproject.toml
still suggestspandas<2.0.0
.