Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance read csv #54

Merged
merged 4 commits into from Apr 13, 2021
Merged

Enhance read csv #54

merged 4 commits into from Apr 13, 2021

Conversation

Flix6x
Copy link
Collaborator

@Flix6x Flix6x commented Apr 4, 2021

Add support to read in a simple time series (two columns) from CSV, provided the caller passes a source and belief time/horizon explicitly (besides the sensor). Not sure if using len(df.columns) == 2 is the best way to distinguish this (arguably common) data format. Should I rather add an explicit boolean option to the function?

@Flix6x Flix6x added the enhancement New feature or request label Apr 4, 2021
@Flix6x Flix6x self-assigned this Apr 4, 2021
@Flix6x Flix6x requested a review from nhoening April 4, 2021 13:02
@Flix6x Flix6x marked this pull request as ready for review April 4, 2021 13:02
timely_beliefs/beliefs/utils.py Show resolved Hide resolved
@Flix6x Flix6x merged commit 4b9bd81 into main Apr 13, 2021
@Flix6x Flix6x deleted the enhance-read_csv branch April 13, 2021 20:02
and the second column has to contain the event values.
You also need to pass explicit values for the belief horizon/time and cumulative probability,
in addition to the sensor and source.
Useful ddditional kwargs passed to pandas are parse_dates=True and infer_datetime_format=True.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: ddditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants