added discord status option #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the option to disable the "downloaded xxxx images" as discord status.
golangcibot
reviewed
Jun 15, 2019
| @@ -98,6 +98,7 @@ func main() { | |||
| cfg.Section("general").NewKey("max download retries", "5") | |||
| cfg.Section("general").NewKey("download timeout", "60") | |||
| cfg.Section("general").NewKey("send notices to interactive channels", "false") | |||
| cfg.Section("general").NewKey("set downloaded image count as discord status", "true") | |||
There was a problem hiding this comment.
Error return value of (*github.com/Seklfreak/discord-image-downloader-go/vendor/gopkg.in/ini.v1.Section).NewKey is not checked (from errcheck)
There was a problem hiding this comment.
I don't see the problem here. Is it a false positive?
ghost
reviewed
Jun 15, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
Frain-Breeze
commented
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the option to disable the "downloaded xxxx images" as discord status.
I personally don't like the status thingy very much, so I thought I might as well add it as an option.