Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another one try of adding new stuff #42

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Another one try of adding new stuff #42

wants to merge 13 commits into from

Conversation

SLASHLogin
Copy link

I hope this time it will end good. If not, please don't close it so fast, beacause I will be trying help you with this so I will change my mistake and adhere to your advices.

@SLASHLogin
Copy link
Author

Uh, I don't where I did mistake

@Seklfreak
Copy link
Owner

You didn't add any option to the config file, you just added a variable. Also you shouldn't use Sprintf when you aren't formatting any text (you have to add a %s placeholder). I'm not sure why you are using Print(/Sprintf) here at all. I'm sorry but I can't merge this.

@Seklfreak Seklfreak closed this Oct 17, 2017
@Seklfreak
Copy link
Owner

I'm reopening it in case you want to submit more, but please make sure it works before you submit it.

@Seklfreak Seklfreak reopened this Oct 17, 2017
@SLASHLogin
Copy link
Author

Thank you so much I will be improving code until I will do that properly. I will add option to config and take look at printing etc.
Anyway sorry because it's not my language and I don't know so good it but I want to help you some way and just trying hard

@SLASHLogin
Copy link
Author

em okay line 1477 just gimme chance

@Seklfreak
Copy link
Owner

I'm pretty busy at the moment but I will look at it, and fix what needs to be fixed when I got time. Please allow me some time. :)

@SLASHLogin
Copy link
Author

I don't see any problems. As I said (or not I'm not sure now) it's completely new lang so sorry for my incompetence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants