New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restartSysCalls is not defined #1251
Comments
Pretty sure it's a typo and should be |
Ping @RGustBardon though - also this should be applied on 1.x AFAIK |
@gmponos: Thank you for reporting the bug! As @Seldaek suggested, it should be
Thank you for attempting to come up with a fix! The idea is as follows: When registering a signal handler, the user can require calling the signal handler previously registered for this signal after the logging of the signal is done. This is what the Another parameter of the Before PHP 7.1, it was not possible to get the current signal handler. Since PHP 7.1, If the user wishes to call the previous signal handler after the logging takes place and Right before making such an attempt, the current signal handler is still the one used for logging. For this reason, the signal handler is temporarily substituted with the default one (the first call to the The current units tests have not been able to identify the problem as they never call @Seldaek: Thank you for bringing the bug to my attention! I have created two pull requests with the same fix (#1252 for the master branch and #1253 for the 1.x branch). |
Fix the property for restarting syscalls (#1251)
…ster Fix the property for restarting syscalls (#1251)
Great, thanks for the fixes :) |
On this line https://github.com/Seldaek/monolog/blob/master/src/Monolog/SignalHandler.php#L96 the
restartSyscalls
is never defined.. I could not understand what the intention was in order to fix it 😞The text was updated successfully, but these errors were encountered: