Monolog Crash on stringify

[molanostephane]

We are using Monolog version 2.0.0 that comes with Laravel 6.2 and we are facing an error when monolog uses the function "stringify" on a trace containing non utf-8 characters (basically when one of the lines of the array "$fields", 1st parameter of the function stringify(), is identified as "binary" by laravel : see screenshot)

The error is the following and you'll find the full trace after (BUG.MONOLOG is an .html changed to .txt)

'Return value of Monolog\Handler\Slack\SlackRecord::stringify() must be of the type string, boolean returned'

BUG MONOLOG.txt

Funny that the error that monolog wanted to return is also affected by this UTF8 problem. This is not the topic, we solved it on our side, but the real problem is that :

Here, we just would like Monolog to be able to log our errors.

Feel free to ask for more questions if you need,

[Seldaek]

I believe this is fixed but would be happy if you can verify this by requiring monolog ^2.0@dev

[mmenozzi]

Hi @Seldaek,
isn't this fix for 1.x a BC break? You removed the public method \Monolog\Formatter\NormalizerFormatter::detectAndCleanUtf8.

[Seldaek]

It had a @private annotation so I'd say it's fine..

[mmenozzi]

Ah ok @Seldaek didn't noticed the @private annotation. Also the IDE (PhpStorm) didn't highlighted as it does when using @internal. I think that @internal is the "standard" annotation to use in such cases (https://docs.phpdoc.org/references/phpdoc/tags/internal.html).

[Seldaek]

Ok good to know, too late to fix this one though :)

…

On Mon, 18 Nov 2019, 18:34 Manuele Menozzi, ***@***.***> wrote: Ah ok @Seldaek <https://github.com/Seldaek> didn't noticed the @Private annotation. Also the IDE (PhpStorm) didn't highlighted as it does when using @internal. I think that @internal is the "standard" annotation to use in such cases ( https://docs.phpdoc.org/references/phpdoc/tags/internal.html). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1392?email_source=notifications&email_token=AABM27WSMYE5EQGD365Z2RDQULG25A5CNFSM4JFYS6C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELINII#issuecomment-555124385>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABM27UBO4QBA6ILBBCQPIDQULG25ANCNFSM4JFYS6CQ> .

[mmenozzi]

Yes no problem man! 😉