Updated constructor params #1174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to pass in host, needed for new Logentries accounts which are now on a different domain.
| @@ -31,13 +31,13 @@ class LogEntriesHandler extends SocketHandler | |||
| * | |||
| * @throws MissingExtensionException If SSL encryption is set to true and OpenSSL is missing | |||
| */ | |||
| public function __construct($token, $useSSL = true, $level = Logger::DEBUG, $bubble = true) | |||
| public function __construct($token, $host = 'data.logentries.com', $useSSL = true, $level = Logger::DEBUG, $bubble = true) | |||
There was a problem hiding this comment.
This should go at the end of the parameter list or it will be a BC break.
There was a problem hiding this comment.
True. I'm using Laravel which automagically passes in the constructor params so I did not catch that.
|
Looks good to me now |
|
Thanks, merged in 1.x and master. |
|
Note that the correct way to do this is to migrate to the InsightOpsHandler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1173
Added ability to pass in host parameter. This is needed for new Logentries accounts which are now on a different domain (rapid7.com).
Note: You also need to pass in
$useSSLasfalsebecause it seems port 443 is not an option on the new domain, but I left it in for backwards compatibility.