Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SlackbotHandler from the docs #1280

Closed
wants to merge 1 commit into from

Conversation

@lightswitch05
Copy link

lightswitch05 commented Jan 18, 2019

SlackbotHandler was deleted by 655b428 - also remove it from the docs

`SlackbotHandler` was deleted by 655b428 - also remove it from the docs
@lightswitch05

This comment has been minimized.

Copy link
Author

lightswitch05 commented Jan 22, 2019

Would anyone be willing to give insights between the reliability of SlackWebhookHandler vs. SlackHandler? Just looking at implementations, it seems to me that SlackHandler is a bit more complicated, and therefore might be a little less reliable then SlackWebhookHandler. Having to read from the socket for the messages to go through definitely appears to be a hack.

@Seldaek

This comment has been minimized.

Copy link
Owner

Seldaek commented Jul 2, 2019

Sorry merged #1328 before I saw this but it does the same so closing here. Thanks for the PR tho.

@Seldaek Seldaek closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.