Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicity void return type to Monolog\Logger #1362

Merged
merged 1 commit into from Aug 15, 2019
Merged

Add explicity void return type to Monolog\Logger #1362

merged 1 commit into from Aug 15, 2019

Conversation

nicolas-grekas
Copy link
Contributor

@nicolas-grekas nicolas-grekas commented Aug 14, 2019

As part of its migration to PHP 7.2, Symfony is starting to require more explicit annotations for return-type. Of course, Monolog cannot add real ones here, due to BC. These declarations would help us (and would make our CI green again as we now have a check to ensure the code and its deps are in good shape in this regard, see e.g. https://travis-ci.org/symfony/symfony/jobs/571836979)

Cannot be applied on branch 1.x since it has conflicting @return bool.

@nicolas-grekas
Copy link
Contributor Author

Now with real return-types, all green.
The change doesn't affect neither the Symfony bridge not the bundle if I made no mistakes.

@Seldaek Seldaek merged commit ccb9961 into Seldaek:master Aug 15, 2019
@Seldaek
Copy link
Owner

Seldaek commented Aug 15, 2019

Thanks, let's hope this goes as planned ;)

@nicolas-grekas nicolas-grekas deleted the void branch August 15, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants