Add explicity void return type to Monolog\Logger #1362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of its migration to PHP 7.2, Symfony is starting to require more explicit annotations for return-type.
Of course, Monolog cannot add real ones here, due to BC.These declarations would help us (and would make our CI green again as we now have a check to ensure the code and its deps are in good shape in this regard, see e.g. https://travis-ci.org/symfony/symfony/jobs/571836979)Cannot be applied on branch 1.x since it has conflicting
@return bool
.