Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not escape forwardslashes on slack #1397

Closed
wants to merge 5 commits into from
Closed

Do not escape forwardslashes on slack #1397

wants to merge 5 commits into from

Commits on Nov 9, 2019

  1. Remove fallback for PHP < 5.4.0 

    Use whitespace in returned data to format it. Available as of PHP 5.4.0.

@see https://www.php.net/manual/en/json.constants.php#constant.json-pretty-print
    @alies-dev
    alies-dev committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    e96a00b View commit details
    Browse the repository at this point in the history

  2. Re-use existing class member

    @alies-dev
    alies-dev committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    df2ac38 View commit details
    Browse the repository at this point in the history

  3. Don't escape forward slashes (solidus) 

    1. it's optional in JSON
2. the main purpose of json encoding for slack it to stringify some types. So, perception is the king, not compatibility (actually we don't need to care about compatibility of JSON format at all)
    @alies-dev
    alies-dev committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    7bd79e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Merge branch 'master' into do-not-escape-forwardslashes-on-slack

    @lptn
    lptn committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    61c4eec View commit details
    Browse the repository at this point in the history

  2. Simplify code: good defaults

    @alies-dev
    alies-dev committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    ddaf77c View commit details
    Browse the repository at this point in the history