Fix JSON formatting of resource type #1410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is well-known that
json_encode
does not handle variables ofresource
type properly. Easiest example is:JsonFormatter of Monolog is affected as well, so it returns empty line if there is a resource in "context".
This pull request leverages already existing code from
NormalizerFormatter
to convert resources tosprintf('[resource(%s)]', get_resource_type($data))
.