Fix failures when SoapFault Detail is an object. #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neclimdul
force-pushed
the
SoapFaultObjectFailure
branch
from
93ac064
to
a09e39b
Compare
|
I don't know if this is the right approach but it is an approach :-D Let me know if you'd like it implemented in a different way. |
neclimdul
force-pushed
the
SoapFaultObjectFailure
branch
from
8b27852
to
2066ce8
Compare
Seldaek
added a commit
that referenced
this pull request
May 21, 2020
|
Thanks, switched it to use $this->toJson so encoding errors can be ignored but otherwise the approach is fine IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.