Added JSON_PARTIAL_OUTPUT_ON_ERROR to the default json encoding options #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially when monolog logs the exception traces (including arguments) there is a chance one of the arguments would contain recursive references, which `json_encode` by default cannot handle. `JSON_PARTIAL_OUTPUT_ON_ERROR` option turns those recursive references to `null` instead. It's available from php 5.5 hence I think should be okay to be added by default.
|
Okay, I realised that it breaks the corresponding test: So please hold on then. The question then is: would the project want to have it at all? (then I will fix tests and write more if necessary) |
|
I think it makes sense yeah, we rather keep as much data as possible in there, fixed the tests quickly. |
|
Thanks for the tip, didn't realize this was there somehow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially when monolog logs the exception traces (including arguments) there is a chance one of the arguments would contain recursive references, which
json_encodeby default cannot handle.JSON_PARTIAL_OUTPUT_ON_ERRORoption turns those recursive references tonullinstead.It's available from php 5.5 hence I think should be okay to be added by default.