Fix - SocketHandler. Set chunkSize default value #1576
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1570
Sets default value of chunkSize to 65023 (a good reasonable number like a UDP datagram size packet).
At the beggining I tried to set it to PHP_INT_MAX (according the documentation in the php website) but I got the following errors while execution the test
testWriteContentWithPlainTextMessage()
:I got it with php 7.4
So according the error , the number candidate
2147483647
is the max allowed.But then I changed my mind and used number
65023
, the same used for UDP packets in the UdpHandler in Monolog.If another number should be use as default, please let me know and I can change the PR asap!
I also fixed/changed some php-doc related issues in the file, and added a simple unit test for this.
Ideas/Suggestions are welcome.