Allow easier extend of BrowserConsoleHandler.php #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warxcell
force-pushed
the
browser_console_handler
branch
from
b700251
to
3d55ecf
Compare
stof
reviewed
Sep 17, 2021
| // This handler only works with HTML and javascript outputs | ||
| // text/javascript is obsolete in favour of application/javascript, but still used | ||
| if (stripos($contentType, 'application/javascript') !== false || stripos($contentType, 'text/javascript') !== false) { | ||
| return static::FORMAT_JS; |
There was a problem hiding this comment.
Yeah on the other hand you used self:: below at line 166. I don't particularly think it matters as nobody should change/override these constants, but it'd be good to at least be consistent about it :)
Warxcell
force-pushed
the
browser_console_handler
branch
from
3d55ecf
to
a3ac34a
Compare
Seldaek
reviewed
Oct 1, 2021
| return static::FORMAT_JS; | ||
| } | ||
| if (stripos($contentType, 'text/html') === false) { | ||
| return null; |
There was a problem hiding this comment.
I do question the value of doing this change to null.. why not keep 'unknown', so it always returns a string? Right now getResponseFormat's return value is broken for example as you didn't update it.
I don't really see the value in deprecating this, except causing more fragmentation in implementations, and added work.
Seldaek
reviewed
Oct 1, 2021
Comment on lines
39
to
40
| public const FORMAT_HTML = 'html'; | ||
| public const FORMAT_JS = 'js'; |
There was a problem hiding this comment.
Suggested change
| public const FORMAT_HTML = 'html'; | |
| public const FORMAT_JS = 'js'; | |
| protected const FORMAT_HTML = 'html'; | |
| protected const FORMAT_JS = 'js'; |
I don't think there's value in this being public
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to get rid of reimplementation of wheel here https://github.com/symfony/symfony/pull/43065/files#diff-b1c0588c5bb7078514aaa70581e920b852b49d9614f687950b6be6495afa7693R29-R42