Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use never return typehint #1654

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Use never return typehint #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4d35b
Use never return typehint
hemberger Apr 18, 2022
90d94a2
Remove redundant "@return never" phpdocs
hemberger Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/Monolog/ErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,7 @@ protected function defaultErrorLevelMap(): array
];
}

/**
* @phpstan-return never
*/
private function handleException(\Throwable $e): void
private function handleException(\Throwable $e): never
{
$level = LogLevel::ERROR;
foreach ($this->uncaughtExceptionLevelMap as $class => $candidate) {
Expand Down
4 changes: 1 addition & 3 deletions src/Monolog/Utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,8 @@ public static function pcreLastErrorMessage(int $code): string
* @param int $code return code of json_last_error function
* @param mixed $data data that was meant to be encoded
* @throws \RuntimeException
*
* @return never
*/
private static function throwEncodeError(int $code, $data): void
private static function throwEncodeError(int $code, $data): never
{
switch ($code) {
case JSON_ERROR_DEPTH:
Expand Down