ElasticSearch v8 support #1662
ElasticSearch v8 support #1662
Conversation
|
Could you update the dependency to |
Seldaek
force-pushed
the
es8
branch
5 times, most recently
from
a5aefb1
to
12eacfa
Compare
|
Well this is a friggin nightmare 😆 If someone has time to take over and fix things before I get to it feel free. |
|
Yup I got that far now that it's running the tests against a real instance but then the elastica handler tests started failing not sure why.. |
| @@ -69,6 +81,14 @@ public function __construct(Client $client, array $options = [], $level = Logger | |||
| ], | |||
| $options | |||
| ); | |||
|
|
|||
| if ($client instanceof Client8 || $client::VERSION[0] === '7') { | |||
There was a problem hiding this comment.
When is this comparison false? Clients before version 7 are not supported
There was a problem hiding this comment.
Well only those versions are used in the tests but we don't enforce it when used within a project so I thought it safer to check and then used the same check in tests for consistency even tho there it's useless.
|
Please have a look on PR #1666 |
Seldaek
force-pushed
the
es8
branch
6 times, most recently
from
1214126
to
e03c96e
Compare
|
Hell of a scope creep here, but I think it's good to merge :) Thanks for the help. |
I'd be happy to have help/guidance here cc @ezimuel
Any other changes required?
#1660 mentioned something about
_typefailing, and I'm not sure what it's about as I have close to no experience with elastic search myself.