Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LevelName enum in favor of a Level::getName method #1668

Merged
merged 1 commit into from May 10, 2022

Conversation

Seldaek
Copy link
Owner

@Seldaek Seldaek commented May 9, 2022

@Seldaek Seldaek added this to the 3.x milestone May 9, 2022
@Seldaek Seldaek merged commit 1dacc79 into main May 10, 2022
@Seldaek Seldaek deleted the remove_level_name branch May 10, 2022 09:15
@tigitz
Copy link

tigitz commented May 10, 2022

@Seldaek Awesome, feels much cleaner. Glad it led to a positive contribution. Thanks for your consideration !

@lyrixx lyrixx mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: Consider merging Level and LevelName enums
3 participants