Fix utf8_encode deprecation #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Jul 22, 2022
Comment on lines
180
to
184
| return base64_encode( | ||
| function_exists('mb_convert_encoding') | ||
| ? mb_convert_encoding($json, 'UTF-8', mb_list_encodings()) | ||
| : utf8_encode($json) | ||
| ); |
There was a problem hiding this comment.
I think we can actually skip the encoding here, as json_encode will produce utf-8 or fail since json must be utf-8. And we also have JSON_INVALID_UTF8_SUBSTITUTE in the Utils::DEFAULT_JSON_FLAGS now so it is really useless I think.
Anyway I'll fix the patch.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1718