Update BrowserConsoleHandler console output method #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there must be a cleaner way to do it. Maybe someone with better knowledge of the base code can make a suggestion. |
|
That looks alright to me but it'd be nice if you can rebase it on the 2.x branch so it can be added to 2.9 release as well. I'll then merge it into main and change it to a match block there which would look a little cleaner. |
Instead of using console.log for all log levels, it uses debug, info, warn and error methods depending on the log level. This makes filtering logs easier in the browser console and highlights error level messages.
pafernandez-oesia
force-pushed
the
patch-1
branch
from
8cb8c62
to
300dda4
Compare
|
I've rebased this same PR on 2.x. Not sure if I've correctly done it, as it is the first time I do this operation. Please, can you check it? |
|
Looks correct yes, thanks. I'm on vacation so merging and releasing will take a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
console.logfor all log levels, it usesdebug,info,warnanderrormethods depending on the log level.This makes filtering logs easier in the browser console and highlights error level messages.