Prometheus grpc histogram always anabled

SeldonIO · May 24, 2023 · 02ed6f5 · 02ed6f5
1 parent 0777b3f
commit 02ed6f5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/mlserver/grpc/server.py b/mlserver/grpc/server.py
@@ -43,9 +43,7 @@ def _create_server(self):
 
         if self._settings.metrics_endpoint:
             interceptors.append(
-                PromServerInterceptor(
-                    enable_handling_time_histogram=self._settings.grpc_response_latency_histogram
-                )
+                PromServerInterceptor(enable_handling_time_histogram=True)
             )
 
         self._server = aio.server(

diff --git a/mlserver/settings.py b/mlserver/settings.py
@@ -92,7 +92,6 @@ def json(self, by_alias=True, exclude_unset=True, exclude_none=True, **kwargs):
 
 
 class CORSSettings(BaseSettings):
-
     class Config:
         env_file = ENV_FILE_SETTINGS
         env_prefix = ENV_PREFIX_SETTINGS
@@ -191,9 +190,6 @@ class Config:
     grpc_max_message_length: Optional[int] = None
     """Maximum length (i.e. size) of gRPC payloads."""
 
-    grpc_response_latency_histogram : bool = False
-    """Enables/Disables the use of a histogram to measure the grpc response latency. This enables a feature of the library used for prometheus grpc instrumentation (https://github.com/lchenn/py-grpc-prometheus#histograms)"""
-
     # CORS settings
     cors_settings: Optional[CORSSettings] = None