Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use qsize for parallel worker queue #1169

Merged
merged 15 commits into from
May 26, 2023

Conversation

adriangonz
Copy link
Contributor

Fixes #1122

Changelog

  • Instead of using multiprocessing.Queue.qsize() (which is not supported in macOS), use the _async_responses dictionary to know how many requests are in-flight.
  • Add OS dimension to GH tests to ensure the package is tested in MacOS.

@adriangonz adriangonz changed the title Don't use qsize for parallel worker queue Don't use qsize for parallel worker queue May 24, 2023
@adriangonz adriangonz merged commit 50c6511 into SeldonIO:master May 26, 2023
50 checks passed
@adriangonz adriangonz deleted the qsize-macos branch May 26, 2023 09:28
adriangonz pushed a commit that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 Error on MacOS
1 participant