Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tracing with OpenTelemetry #1281

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

vtaskow
Copy link
Contributor

@vtaskow vtaskow commented Jul 4, 2023

Resolves #39
The intention is the whole Seldon Core v2 ecosystem to have enabled distributed tracing. Currently, MLServer is missing this and this PR tracing features via the OpenTelemetry Python SDK. Other components of the system already have tracing enabled and exporting traces to an OTel collector service. By having it enabled in settings, it will provide transparency on requests, helping us to get a better picture of the journey of a request and identify any potential or already existing bottlenecks.
This PR adds basic tracing functionality by instrumenting both the REST and the gRPC servers on start. And adds a few tests to verify spans are being sent out. This is enough to give us basic information about incoming requests and their life-cycle in MLServer.

@vtaskow vtaskow changed the title Introduce otel Introduce OpenTelemetry Tracing Jul 4, 2023
@vtaskow vtaskow changed the title Introduce OpenTelemetry Tracing Introduce tracing with OpenTelemetry Jul 4, 2023
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @vtaskow! PR looks great! 🚀

I've added a couple questions, but it's pretty much ready to go.

docs/examples/sklearn/playing_with_sklearn.py Outdated Show resolved Hide resolved
mlserver/settings.py Show resolved Hide resolved
tests/tracing/conftest.py Show resolved Hide resolved
@adriangonz adriangonz marked this pull request as ready for review July 5, 2023 09:07
@adriangonz adriangonz merged commit ab448f8 into SeldonIO:master Jul 5, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for tracing
2 participants