Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in conda version and mamba solver #1298

Merged
merged 29 commits into from
Aug 10, 2023
Merged

Conversation

dtpryce
Copy link
Contributor

@dtpryce dtpryce commented Jul 14, 2023

  • Bump conda to 22.11.1
  • Install and set solver to libmamba
  • Tested with a custom runtime build - much much faster
  • Tested running the server based on docker image in V2
  • Removed the quiet from the build after devs complained they wanted it back there but not from server starting like Conda pack unsilent #1296

Should solve #1297

@Kolajik Kolajik mentioned this pull request Jul 14, 2023
Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @dtpryce! 🚀

Added a small comment around the Conda version, but everything else looks good! Once this is in, we may also look into enabling libmamba at the base Dockerfile image.

mlserver/cli/constants.py Show resolved Hide resolved
@adriangonz adriangonz merged commit cfac1b9 into SeldonIO:master Aug 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants