Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to custom runtimes #1467

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix link to custom runtimes #1467

merged 1 commit into from
Oct 30, 2023

Conversation

kretes
Copy link
Contributor

@kretes kretes commented Oct 30, 2023

No description provided.

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot @kretes ! Thanks for fixing this one.

Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR fixes anything for how the docs are meant to be viewed -- browsing the runtimes page and clicking the relevant link for custom runtimes works fine for me.

I suspect this is about the docs not linking correctly when browsing in GitHub, but that's a suboptimal experience in any case, as this is a Sphinx project rather than pure Markdown and various things don't render correctly.

With that sald, I'll check this doesn't break anything, as I think Sphinx is generally permissive about .md vs. .html vs. `` endings for links, although sometimes it's more particular.

Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running docs locally, this change looks to still work, so fine from my side too

@adriangonz adriangonz merged commit 554fe37 into SeldonIO:master Oct 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants