Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing on Environment class #1469

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Improve typing on Environment class #1469

merged 1 commit into from
Nov 1, 2023

Conversation

krishanbhasin-gc
Copy link
Contributor

Per title; added return type of Environment to __enter__() as it was missing

@krishanbhasin-gc
Improve typing on Environment class
4fe0f17 
Added return type to `__enter__()`
agrski
agrski reviewed Nov 1, 2023
View reviewed changes
mlserver/env.py Show resolved Hide resolved
@agrski agrski merged commit 12e1b37 into SeldonIO:master Nov 1, 2023
30 checks passed
@krishanbhasin-gc krishanbhasin-gc deleted the patch-1 branch November 1, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklaise jklaise jklaise left review comments

@agrski agrski agrski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krishanbhasin-gc @jklaise @agrski