Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLServer changes from internal fork - deps and CI updates #1588

Merged
merged 11 commits into from
Feb 28, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Feb 28, 2024

These are changes done internally on a private fork and include changes to CI and upgrading packages.

@sakoush sakoush changed the title These are changes done internally on a private fork and include changes to CI and upgrading packages. MLServer changes from internal fork - deps and CI updates Feb 28, 2024
@sakoush sakoush requested a review from jesse-c February 28, 2024 12:01
@sakoush
Copy link
Member Author

sakoush commented Feb 28, 2024

failing error on CI is tests/cli/test_build.py::test_infer_custom_runtime[environment_yml]
it runs fine locally so we probably need to fix it later post this PR.
image

Copy link
Contributor

@jesse-c jesse-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For the failing error, that makes sense, especially if it's consistent on being that one.

@sakoush sakoush merged commit a2ed772 into SeldonIO:master Feb 28, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants